Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PartialExecuter getPointerElementType #214

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

Hyxogen
Copy link
Contributor

@Hyxogen Hyxogen commented Feb 14, 2024

Still a draft since I want to do some testing

The intrinsic llvm.cheerp.element.distance was removed in:
edddf50
@Hyxogen Hyxogen requested a review from yuri91 February 14, 2024 11:46
@yuri91
Copy link
Member

yuri91 commented Feb 14, 2024

it looks like the first argument does not need to be Function* but can stay FunctionType*?

@Hyxogen
Copy link
Contributor Author

Hyxogen commented Feb 14, 2024

it looks like the first argument does not need to be Function* but can stay FunctionType*?

Now that you mention it, indeed. I'll revert it to FunctionType*

@Hyxogen Hyxogen marked this pull request as ready for review February 14, 2024 12:45
@Hyxogen
Copy link
Contributor Author

Hyxogen commented Feb 14, 2024

@yuri91 I've done my tests and should be ok to merge

@yuri91 yuri91 force-pushed the replace-pe-getpointerelement branch from 153b4b7 to 70789e7 Compare February 14, 2024 12:56
@yuri91 yuri91 merged commit d13608e into master Feb 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants